Conversation
Author
|
This pull depends on another pull request for js-multiaddr. [edit] That pull has been merged |
Author
|
Can I get some feedback on this? |
This was referenced Jun 6, 2019
|
@pldespaigne Can you please take a look at this? We'd like to add support to the ENS manager, but we can't until this is merged. |
Owner
Author
|
Absolutely, I'm by no mean an expert developer, I just needed a way to encode onion addresses for the ens-app, but a general encoding would definitely be the way to go. |
Author
|
Hi @pldespaigne , are you working on the general encoding by any chance? |
Owner
|
Hi, I don't have so much time currently, but it will be done before Sunday evening ! |
Owner
Author
|
Thanks! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I extended the module to encode and decode .onion (tor) addresses. I'm planning to use this to extend the ens-app repo.